Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling SteamVR_ControllerManager multiple times adds multiple instances of left/right #33

Closed
aleiby opened this issue Apr 18, 2017 · 2 comments

Comments

@aleiby
Copy link
Contributor

aleiby commented Apr 18, 2017

Maybe use HashSet to avoid duplicate entries when updating this.objects.

@aleiby
Copy link
Contributor Author

aleiby commented Apr 24, 2017

This should also fix the double hide issue.

Repro steps:

  • Attach both controllers in Steam VR_Controller Manager in the named slots ('Left' and 'Right')
  • Attach both controllers in Steam VR_Controller Manager to the 'objects' array
  • Start the app and hit the Steam Menu button to get to the Steam Menu
  • Hit the Steam Menu button again to exit back to your app -- your controller models have now irreversibly disappeared

The issue comes that the controller gameobjects under CameraRig are hidden twice if they exist in both Left/Right and 'objects', but only unhidden once. Hiding consists of creating a new GameObject called 'hidden' and making it a parent of the controller gameobjects, and is presumably done somewhere within the SteamVR plugin.

@aleiby
Copy link
Contributor Author

aleiby commented Jun 16, 2017

Fixed in next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant