optimize:reduce loop (#1532)

valyala · Mar 28, 2023 · 5209cc3 · 5209cc3
1 parent 0be5a41
commit 5209cc3
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/lbclient.go b/lbclient.go
@@ -112,16 +112,14 @@ func (cc *LBClient) AddClient(c BalancingClient) int {
 func (cc *LBClient) RemoveClients(rc func(BalancingClient) bool) int {
 	cc.mu.Lock()
 	n := 0
-	for _, cs := range cc.cs {
+	for idx, cs := range cc.cs {
+		cc.cs[idx] = nil
 		if rc(cs.c) {
 			continue
 		}
 		cc.cs[n] = cs
 		n++
 	}
-	for i := n; i < len(cc.cs); i++ {
-		cc.cs[i] = nil
-	}
 	cc.cs = cc.cs[:n]
 
 	cc.mu.Unlock()