Fix userdata re-use after Remove

See also: #1298
valyala · May 11, 2022 · 9961079 · 9961079
1 parent 7cc6f4c
commit 9961079
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/userdata.go b/userdata.go
@@ -81,7 +81,7 @@ func (d *userData) Remove(key string) {
 		kv := &args[i]
 		if string(kv.key) == key {
 			n--
-			args[i] = args[n]
+			args[i], args[n] = args[n], args[i]
 			args[n].value = nil
 			args = args[:n]
 			*d = args

diff --git a/userdata_test.go b/userdata_test.go
@@ -104,3 +104,18 @@ func TestUserDataDelete(t *testing.T) {
 	}
 
 }
+
+func TestUserDataSetAndRemove(t *testing.T) {
+	var (
+		u        userData
+		shortKey = "[]"
+		longKey  = "[  ]"
+	)
+
+	u.Set(shortKey, "")
+	u.Set(longKey, "")
+	u.Remove(shortKey)
+	u.Set(shortKey, "")
+	testUserDataGet(t, &u, []byte(shortKey), "")
+	testUserDataGet(t, &u, []byte(longKey), "")
+}