Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Char conversion to hex code in header #141

Closed
grunmax opened this issue Jul 17, 2016 · 1 comment
Closed

Char conversion to hex code in header #141

grunmax opened this issue Jul 17, 2016 · 1 comment
Labels
bug

Comments

@grunmax
Copy link

grunmax commented Jul 17, 2016

Hi Val,
can you look at this conversion?
// GET
// req - *fasthttp,Request
req.Header.Set("Cookie", "ID&14")

finally it converts to:
Cookie: ID%2614

Thanks!
@valyala valyala added the bug label Jul 18, 2016
valyala added a commit that referenced this issue Jul 18, 2016
@valyala
Issue #141: do not urlencode cookies
45697fe 
https://tools.ietf.org/html/rfc6265 says nothing about cookies encoding.
@valyala
Copy link
Owner

valyala commented Jul 18, 2016

@grunmax , the issue should be fixed now.

@valyala valyala closed this as completed Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valyala @grunmax