feat: support custom formvalue function #1453

li-jin-gou · 2022-12-08T12:18:28Z

Some gin or net/http services have a different formvalue function when migrating to fasthttp.
it maybe causes some bugs.

net/http:

// FormValue returns the first value for the named component of the query.
// POST and PUT body parameters take precedence over URL query string values.
// FormValue calls ParseMultipartForm and ParseForm if necessary and ignores
// any errors returned by these functions.
// If key is not present, FormValue returns the empty string.
// To access multiple values of the same key, call ParseForm and
// then inspect Request.Form directly.

The user can customize a formvalue function to avoid this problem, but it would be better if the framework provided this switch.

erikdubbelboer

Do you have a real world example of this going wrong or is it something you think might go wrong?

erikdubbelboer · 2022-12-10T03:32:10Z

server.go

+	return defaultFormValue(ctx, key)
+}
+
+type FormValue func(*RequestCtx, string) []byte


Suggested change

type FormValue func(*RequestCtx, string) []byte

type FormValueFunc func(*RequestCtx, string) []byte

erikdubbelboer · 2022-12-10T03:32:10Z

server.go

+
+// SetStandardFormValueFunc sets FormValue function implementation to get form value.
+// Consistent behaviour with net/http. POST and PUT body parameters take precedence over URL query string values.
+func SetStandardFormValueFunc() {


Suggested change

func SetStandardFormValueFunc() {

func SetNetHttpFormValueFunc() {

li-jin-gou · 2022-12-10T03:41:44Z

Do you have a real world example of this going wrong or is it something you think might go wrong?

Yes, there was a problem with the code in the real environment and I noticed the difference. the front end passes the same parameters and different values in the http body and query and result in an unintended bug...😩

erikdubbelboer · 2022-12-24T04:41:43Z

server.go

@@ -412,6 +412,7 @@ type Server struct {
 	concurrencyCh    chan struct{}
 	perIPConnCounter perIPConnCounter
 	serverName       atomic.Value
+	FormValueFunc    FormValueFunc


This field needs some documentation since it's exposed.

thanks and done

erikdubbelboer · 2022-12-24T04:41:43Z

server.go

-		if len(vv) > 0 {
-			return []byte(vv[0])
+
+	// NetHttpFormValueFunc Consistent behaviour with net/http. POST and PUT body parameters take precedence over URL query string values.


Suggested change

// NetHttpFormValueFunc Consistent behaviour with net/http. POST and PUT body parameters take precedence over URL query string values.

// NetHttpFormValueFunc gives consistent behavior with net/http. POST and PUT body parameters take precedence over URL query string values.

erikdubbelboer · 2022-12-25T08:37:54Z

Thanks!

li-jin-gou force-pushed the feat/add_custom_formvalue_func branch from 3a67d42 to efe5988 Compare December 8, 2022 12:23

erikdubbelboer requested changes Dec 10, 2022

View changes

li-jin-gou force-pushed the feat/add_custom_formvalue_func branch from efe5988 to 011607d Compare December 10, 2022 03:38

li-jin-gou force-pushed the feat/add_custom_formvalue_func branch 3 times, most recently from faf8119 to f58e4ab Compare December 15, 2022 15:02

erikdubbelboer requested changes Dec 24, 2022

View changes

li-jin-gou force-pushed the feat/add_custom_formvalue_func branch 3 times, most recently from e8e52d2 to 56a135e Compare December 24, 2022 17:50

feat: support custom formvalue function

09b5fcc

li-jin-gou force-pushed the feat/add_custom_formvalue_func branch from 56a135e to 09b5fcc Compare December 24, 2022 17:52

erikdubbelboer merged commit b788e66 into valyala:master Dec 25, 2022
12 of 14 checks passed

feat: support custom formvalue function #1453

feat: support custom formvalue function #1453

li-jin-gou commented Dec 8, 2022 •

edited

erikdubbelboer left a comment

erikdubbelboer Dec 10, 2022

li-jin-gou Dec 10, 2022

erikdubbelboer Dec 10, 2022

li-jin-gou Dec 10, 2022

li-jin-gou commented Dec 10, 2022 •

edited

erikdubbelboer Dec 24, 2022

li-jin-gou Dec 24, 2022

erikdubbelboer Dec 24, 2022

li-jin-gou Dec 24, 2022

erikdubbelboer commented Dec 25, 2022

	type FormValue func(*RequestCtx, string) []byte
	type FormValueFunc func(*RequestCtx, string) []byte

	func SetStandardFormValueFunc() {
	func SetNetHttpFormValueFunc() {

	// NetHttpFormValueFunc Consistent behaviour with net/http. POST and PUT body parameters take precedence over URL query string values.
	// NetHttpFormValueFunc gives consistent behavior with net/http. POST and PUT body parameters take precedence over URL query string values.

feat: support custom formvalue function #1453

feat: support custom formvalue function #1453

Conversation

li-jin-gou commented Dec 8, 2022 • edited

erikdubbelboer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

li-jin-gou commented Dec 10, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erikdubbelboer commented Dec 25, 2022

li-jin-gou commented Dec 8, 2022 •

edited

li-jin-gou commented Dec 10, 2022 •

edited