New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace path.Join with filepath.Join in tests #1623

Merged

erikdubbelboer merged 1 commit into valyala:master from alexandear:refactor-test-filepath-join

Sep 18, 2023

Contributor

alexandear commented Sep 18, 2023 •

edited

Loading

Because path.Join is for URL paths, and filepath.Join is for file paths.


          Replace path.Join with filepath.Join in tests

30f02c8

erikdubbelboer merged commit a5301d9 into valyala:master

12 of 14 checks passed

Collaborator

erikdubbelboer commented Sep 18, 2023

Thanks!

alexandear deleted the refactor-test-filepath-join branch

September 18, 2023 19:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment