New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove redundant and outdated build constraints #1650

Merged

erikdubbelboer merged 1 commit into valyala:master from alexandear:chore-remove-redundant-build-constraints

Nov 8, 2023

Contributor

alexandear commented Nov 8, 2023

This PR removes outdated // +build constraints (it was replaced by //go:build in Go 16) by running go fix ./....

We can remove OS-specific build constraints like //go:build windows if a file name ends with _windows.go (according to the doc).


          chore: Remove redundant build constraint

d9e8aee

alexandear changed the title ~~chore: Remove redundant build constraint~~ chore: Remove redundant and outdated build constraints

alexandear mentioned this pull request

Copy maps using Go 1.21's new "maps" package #1648

Closed

erikdubbelboer merged commit 7bd632c into valyala:master

13 of 14 checks passed

Collaborator

erikdubbelboer commented Nov 8, 2023

Thanks!

alexandear deleted the chore-remove-redundant-build-constraints branch

November 9, 2023 10:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment