Adds support for max-age cookie value. Fixes #184 #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbyttow
force-pushed
the
cookie-max-age
branch
from
3cdc245
to
614ea5d
Compare
Closed
kirillDanshin
approved these changes
Sep 11, 2018
davidbyttow
force-pushed
the
cookie-max-age
branch
from
614ea5d
to
cefc5a8
Compare
davidbyttow
force-pushed
the
cookie-max-age
branch
from
cefc5a8
to
e4c472a
Compare
|
@erikdubbelboer good for merge? |
erikdubbelboer
requested changes
Sep 12, 2018
cookie.go
Outdated
| @@ -52,6 +53,7 @@ type Cookie struct { | |||
| key []byte | |||
| value []byte | |||
| expire time.Time | |||
| maxAge time.Time | |||
There was a problem hiding this comment.
I think maxAge should be kept as int.
cookie.go
Outdated
| @@ -203,6 +213,10 @@ func (c *Cookie) AppendBytes(dst []byte) []byte { | |||
| } | |||
| dst = append(dst, c.value...) | |||
|
|
|||
| if !c.maxAge.IsZero() { | |||
| ts := strconv.Itoa(int(c.maxAge.Unix())) | |||
There was a problem hiding this comment.
Please use c.bufKV.value = AppendUint(... so we don't have a heap allocation here.
cookie.go
Outdated
| if !c.maxAge.IsZero() { | ||
| ts := strconv.Itoa(int(c.maxAge.Unix())) | ||
| dst = appendCookiePart(dst, strCookieMaxAge, []byte(ts)) | ||
| } |
There was a problem hiding this comment.
I think this the line below should be else if so we can't set both.
cookie.go
Outdated
| @@ -319,6 +342,19 @@ func (c *Cookie) ParseBytes(src []byte) error { | |||
| return nil | |||
| } | |||
|
|
|||
| var errInvalidMaxAge = errors.New("max-age must be non-zero digit") | |||
|
|
|||
| func parseTimestamp(b []byte) (time.Time, error) { | |||
There was a problem hiding this comment.
max-age is not a timestamp, max-age is the number of seconds the cookie should live from the time you receive it!
There was a problem hiding this comment.
Fix this first and then we'll look at the tests.
|
Addressed feedback @erikdubbelboer, made the API simple and only removes expires if max-age is set. |
davidbyttow
force-pushed
the
cookie-max-age
branch
from
1b80424
to
05b5485
Compare
davidbyttow
force-pushed
the
cookie-max-age
branch
from
05b5485
to
c948f6f
Compare
erikdubbelboer
approved these changes
Sep 13, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #184
Note, because
max-agetakes precedence over expires, it only supportsmax-agewhen encoded/decoded. However, it does not allow the client to setmax-ageat the API and prefersSetExpireinstead.