#457: allow to rewrite system error response #458
Conversation
|
I think this is a feature other people have requested before. I would like to see some changes to make this more usable before I can accept it. I think it would be useful to add some documentation on what kind of errors the user can expect as argument to the |
|
Thanks for review. All fixes are done |
derElektrobesen
force-pushed
the
issue-457
branch
from
7d8045c
to
aa16fe7
Compare
http.go
Outdated
| @@ -1652,6 +1654,11 @@ func appendBodyFixedSize(r *bufio.Reader, dst []byte, n int) ([]byte, error) { | |||
| } | |||
| } | |||
|
|
|||
| // ErrBrokenChunks is returned when server got broken chunked body (Transfer-Encoding: chunked). | |||
There was a problem hiding this comment.
Can you change this to:
ErrBrokenChunks is returned when server receives a broken chunked body (Transfer-Encoding: chunked).
http.go
Outdated
| @@ -847,7 +847,9 @@ func (req *Request) Read(r *bufio.Reader) error { | |||
|
|
|||
| const defaultMaxInMemoryFileSize = 16 * 1024 * 1024 | |||
|
|
|||
| var errGetOnly = errors.New("non-GET request received") | |||
| // ErrGetOnly is returned when server expects only GET requests, | |||
| // but some other type of request came (Server.GetOnly option is enabled). | |||
There was a problem hiding this comment.
Can you change enabled to true.
server.go
Outdated
| @@ -152,6 +152,17 @@ type Server struct { | |||
| // Handler for processing incoming requests. | |||
| Handler RequestHandler | |||
|
|
|||
| // ErrorHandler for returning an error response in user-defined way. | |||
There was a problem hiding this comment.
Can you change this to:
ErrorHandler for returning a response in case of an error while receiving or parsing the request.
server.go
Outdated
| @@ -152,6 +152,17 @@ type Server struct { | |||
| // Handler for processing incoming requests. | |||
| Handler RequestHandler | |||
|
|
|||
| // ErrorHandler for returning an error response in user-defined way. | |||
| // | |||
| // Following errors will be captured with this handler: | |||
There was a problem hiding this comment.
Since I'm not sure if these are really all the errors (I think more io.* errors are possible it's probably better to change this to:
The following is a non-exhaustive list of errors that can be expected as argument:
http.go
Outdated
| @@ -1652,6 +1654,11 @@ func appendBodyFixedSize(r *bufio.Reader, dst []byte, n int) ([]byte, error) { | |||
| } | |||
| } | |||
|
|
|||
| // ErrBrokenChunks is returned when server got broken chunked body (Transfer-Encoding: chunked). | |||
| type ErrBrokenChunks struct { | |||
There was a problem hiding this comment.
Sorry for being pedantic but can you change this to ErrBrokenChunk. The error is only about one chunk being broken, not multiple.
|
Sorry about my english %) Just I need more practice. |
No description provided.