Add test cases for StreamRequestBody #915
Conversation
|
@erikdubbelboer, do you mind reviewing the changes? |
server_test.go
Outdated
| if err != nil { | ||
| t.Error(err) | ||
| } | ||
| case <-time.After(100 * time.Millisecond): |
There was a problem hiding this comment.
This timeout should be higher as it is constantly failing on travis-ci.
|
When I don’t use |
server_test.go
Outdated
| Handler: func(ctx *RequestCtx) { | ||
| checkReader(t, ctx.RequestBodyStream(), part1) | ||
| close(next) | ||
| <-done |
There was a problem hiding this comment.
Instead of adding the done channel I think it's probably a better idea to add a sync.Mutex to readWriter to make its operations safe just like reading and writing on a normal socket would be.
There was a problem hiding this comment.
I think we can't use sync.Mutex. If handler get lock first, then second part can't be sent, and the test case will timeout.
So we should use a more real Conn. Let me try it.
There was a problem hiding this comment.
Use fasthttputil.NewPipeConns() now.
server_test.go
Outdated
| if _, err := cc.Write([]byte(fmt.Sprintf("POST /foo2 HTTP/1.1\r\nHost: aaa.com\r\nContent-Length: %d\r\nContent-Type: aa\r\n\r\n%s", contentLength, part1))); err != nil { | ||
| t.Error(err) | ||
| } | ||
| }() |
There was a problem hiding this comment.
There is no reason to do this in a goroutine. If you move the ch <- s.ServeConn(sc) gorourine up to before this Write then you don't have to do this Write or the one below it in goroutines.
There was a problem hiding this comment.
You're right, thanks!
Co-authored-by: Fenny fenny@gofiber.io
Related to #911