Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump serde_yaml from 0.8.15 to 0.8.16 in /packer #6

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Feb 4, 2021

Bumps serde_yaml from 0.8.15 to 0.8.16.

Release notes

Sourced from serde_yaml's releases.

0.8.16

  • Add a Serializer and Deserializer type (#185, #186)

    let mut buffer = Vec::new();
    let mut ser = serde_yaml::Serializer::new(&mut buffer);
    let mut object = BTreeMap::new();
    object.insert("k", 107);
    object.serialize(&mut ser)?;
    let de = serde_yaml::Deserializer::from_slice(&buffer);
    let value = Value::deserialize(de)?;
    println!("{:?}", value);

  • Support multi-doc serialization (#187)

    let mut buffer = Vec::new();
    let mut ser = serde_yaml::Serializer::new(&mut buffer);
    let mut object = BTreeMap::new();
    object.insert("k", 107);
    object.serialize(&mut ser)?;
    object.insert("j", 106);
    object.serialize(&mut ser)?;
    assert_eq!(buffer, b"---\nk: 107\n...\n---\nj: 106\nk: 107\n");

  • Support multi-doc deserialization (#189)

    let input = "---\nk: 107\n...\n---\nj: 106\n";
    for document in serde_yaml::Deserializer::from_str(input) {
    let value = Value::deserialize(document)?;
    println!("{:?}", value);
    }

Commits
  • 02e9940 Release 0.8.16
  • 667bd47 Merge pull request #190 from dtolnay/doc
  • 52de1e0 Fix Serializer example code on rustc pre-1.47
  • 5b91abf Add multi-doc examples
  • cfe758b Merge pull request #189 from dtolnay/multide
  • 2903742 Support multi-doc deserialization
  • 037519e Merge pull request #188 from dtolnay/shared
  • 2700f69 Ignore unused Shared error until multi-doc deserialization
  • 4200736 Add an error variant with shared ownership
  • 7ea4775 Factor out error trait impls to work without outer Error wrapper
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.8.15 to 0.8.16.
- [Release notes](https://github.com/dtolnay/serde-yaml/releases)
- [Commits](dtolnay/serde-yaml@0.8.15...0.8.16)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Feb 4, 2021
@coveralls
Copy link

coveralls commented Feb 4, 2021

Pull Request Test Coverage Report for Build 536670316

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 46.298%

Files with Coverage Reduction New Missed Lines %
desktop/app/src/sandy-chrome/appinspect/LaunchEmulator.tsx 2 62.69%
desktop/app/src/MenuBar.tsx 8 31.84%
Totals Coverage Status
Change from base Build 536668078: 0.1%
Covered Lines: 5675
Relevant Lines: 11050

💛 - Coveralls

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Feb 15, 2021

Superseded by #26.

@dependabot dependabot bot closed this Feb 15, 2021
@dependabot dependabot bot deleted the dependabot/cargo/packer/serde_yaml-0.8.16 branch February 15, 2021 13:02
vamshi9666 pushed a commit that referenced this pull request Sep 6, 2021
Summary:
This diff fixes deadlock that happens on mutex [FlipperClient::mutex_](https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/sonar/xplat/Flipper/FlipperClient.h?commit=9eba9f832dfb648788d4c0e6ae05712e30a59a21&lines=113).

Steps that cause a deadlock:
1. Mutex is locked at [FlipperClient.cpp:170](https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/sonar/xplat/Flipper/FlipperClient.cpp?commit=750ee132616cd3c470d8d091532a853e6b44f6d6&lines=170)
2. `FlipperConnectionImpl::call` executed at [FlipperClient.cpp:237](https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/sonar/xplat/Flipper/FlipperClient.cpp?commit=750ee132616cd3c470d8d091532a853e6b44f6d6&lines=237)
3. `FlipperConnectionImpl::call` eventually calls `FlipperClient::getPlugin()` (see fullstacktrace below) which is trying to lock the same [FlipperClient::mutex_](https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/sonar/xplat/Flipper/FlipperClient.h?commit=9eba9f832dfb648788d4c0e6ae05712e30a59a21&lines=113) as in step 1.

Full stacktrace: P420350989. Mutex is locked in frame #43 and attempted to be locked in frame #6.
More details: T92341964

Solution: unlock the mutex before calling `FlipperConnectionImpl::call` at [FlipperClient.cpp:237](https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/sonar/xplat/Flipper/FlipperClient.cpp?commit=750ee132616cd3c470d8d091532a853e6b44f6d6&lines=237)

Reviewed By: jknoxville

Differential Revision: D28918093

fbshipit-source-id: 06c7841740a70e117dc5f767f9d5852149974f7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
1 participant