vanadium-js-browser-integration is flaky

[tatatodd]

The following test is flaky when run in presubmit. Flaky as in it'll sporadically fail, and will succeed when re-run without changing anything in my CLs.

javascript.browser.[test/integration/test-server-serve.js].Test serving a JS service under multiple names - runtime．addName(name), runtime．removeName(name).#754 should not be able to bind to a removed name

https://veyron.corp.google.com/jenkins/job/vanadium-presubmit-test/ARCH=amd64,OS=linux,TEST=vanadium-js-browser-integration/7633/

18:11:58 not ok 754 should not be able to bind to a removed name
18:11:58 ---
18:11:58 operator: fail
18:11:58 at: Test.assert (http://0.0.0.0:7559/assets/run.js:8097:17)
18:11:58 ...

[afandria]

@bprosnitz has started to look at this.

[bjornick]

It looks like removeName returns before the name is removed from the mounttable.

@tatatodd is this expected behavior?

[ghost]

I think Cos recently made the server methods reliably async. Before they were sometimes synchronous and sometimes async.

[bprosnitz]

The "fix" in my branch is just add a 100ms delay so the test passes. I
haven't had a chance to look into how to make it work correctly yet.

On Wed, Jun 3, 2015 at 3:50 AM Matt Rosencrantz notifications@github.com
wrote:

I think Cos recently made the server methods reliably async. Before they
were sometimes synchronous and sometimes async.

—
Reply to this email directly or view it on GitHub
#518 (comment).