Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place to host *.mojo files #834

Open
afandria opened this issue Oct 27, 2015 · 2 comments
Open

Place to host *.mojo files #834

afandria opened this issue Oct 27, 2015 · 2 comments
Assignees
@aghassemi
Labels
Area: Core Area: Syncbase

Comments

@afandria
Copy link

Instead of having to point to the exact directories of the *.mojo files (Mojo shell's config file and --map-origin flag), it would be better if we served all our mojo files from a single place. Right now, syncbase.mojo, discovery.mojo, and v23proxy.mojo are scattered across different folders and packages.

For example, the Flutter team serves sky_viewer.mojo from storage.googleapis. They add a commit hash (or identifier) in each Dart package published to point to the correct version of the sky viewer. This versioning strategy works well for a single binary, but we'll need an alternative since we have multiple binaries.

I am not familiar with publishing versioned binaries this way, so if someone else wants to tackle this, feel free to take charge.

@nlacasse @aghassemi
@afandria afandria self-assigned this Oct 27, 2015
@aghassemi
Copy link
Member

I can take this.

@aghassemi aghassemi assigned aghassemi and unassigned afandria Oct 27, 2015
@afandria
Copy link
Author

I have put a few files up on storage.googleapis.com, but we will need to improve our versioning strategy in the future. We could use a commit hash the way that Flutter does it. Since Syncbase and Discovery are in different repositories, they can use their distinct commit hashes. Croupier and Syncslides can do the same.

afandria added a commit to vanadium-archive/croupier that referenced this issue Nov 25, 2015
@afandria
croupier: Add Shortcut creation logic to Makefile
a0bba29 
This adds a way to create shortcuts to the Makefile.
While this does belong in mojo.shared, this is here because of the
recent refactoring done there. The next CL will MultiPart the relevant
repositories.

mojo.shared's macro will need to take 5 variables:
* Target device ID Flag (optional)
* Shortcut Name (required)
* Shortcut Mojo Url (required)
* Shortcut Icon Url (optional)
* Shell command path (required)

vanadium/issues#942

The Shortcut also requires some assets to be loaded onto a public and
secure location, like storage.googleapis.com. For now, I have manually
put a few of our binaries up there, though in the future we will also
want to version them.

vanadium/issues#834

The related files are:
* Makefile
* shortcut_template
* .gitignore

=========================

The other files are actually part of a related change.

This other half modifies the Hearts and Croupier Game implementations.
A new signal called startGameSignal is called at the start of a game.
This allows Hearts to send a Ready command when the button is pressed.
This allows Deal to occur independently of the other players, since the
owner is known, and we can let them deal.
The tests were updated to correspond with this change.

Change-Id: I1acf494c45d7d3d9dda3acba815a3fe63a13e966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghassemi aghassemi

Labels
Area: Core Area: Syncbase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aghassemi @afandria