Skip to content

Commit

Permalink
Fix #144; memory component doesn't enable OK button correctly
Browse files Browse the repository at this point in the history
  • Loading branch information
vanderlee committed Feb 12, 2018
1 parent f672b1d commit 39c1d77
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 16 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## 1.2.15 - 2018-02-12
### Fixed
- Fix #144 by @Backslider23; memory part doesn't enable OK button correctly.
- Fixed black initialization issue in rgbslider part.

## 1.2.14 - 2017-12-10
### Added
- PR #143 by @zaeder; `ready` event at end of widget creation.
Expand Down
2 changes: 1 addition & 1 deletion README.md
@@ -1,6 +1,6 @@
jQuery.colorpicker
==================
Version 1.2.14
Version 1.2.15

[![License](https://img.shields.io/github/license/vanderlee/colorpicker.svg)]()

Expand Down
2 changes: 1 addition & 1 deletion bower.json
@@ -1,6 +1,6 @@
{
"name": "colorpicker",
"version": "1.2.13",
"version": "1.2.15",
"homepage": "https://github.com/vanderlee/colorpicker",
"authors": [
"Martijn van der Lee <martijn@vanderlee.com>"
Expand Down
6 changes: 3 additions & 3 deletions demo.html
Expand Up @@ -164,9 +164,9 @@ <h2>Events</h2>
$(function() {
var count = 0;

function addToEventLog(label, color) {
var line = '<div>#'+(++count)+' '+label+': '+message+'</div>';
var log = $('.cp-events-log');
function addToEventLog(label, message) {
var line = '<div>#'+(++count)+' '+label+': '+message+'</div>',
log = $('.cp-events-log');
log.append(line).scrollTop(log[0].scrollHeight);
}

Expand Down
2 changes: 1 addition & 1 deletion jqcolorpicker.jquery.json
@@ -1,6 +1,6 @@
{
"name": "jqcolorpicker",
"version": "1.2.13",
"version": "1.2.15",
"title": "Vanderlee Colorpicker",
"description": "JQuery colorpicker with themeroller styling, RGB, HSL, CMYK and L*A*B support. Standard look & feel, configurable layout. Works as a popup or inline.",
"author": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "vanderlee-colorpicker",
"version": "1.2.13",
"version": "1.2.15",
"homepage": "https://github.com/vanderlee/colorpicker",
"author": "Martijn van der Lee <martijn@vanderlee.com>",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion parts/jquery.ui.colorpicker-memory.js
Expand Up @@ -3,7 +3,7 @@
var that = this,
container,
selectNode = function(node) {
inst._setColor($(node).css('backgroundColor'));
inst.color = inst._parseColor($(node).css('backgroundColor'));
inst._change();
},
deleteNode = function(node) {
Expand Down
21 changes: 13 additions & 8 deletions parts/jquery.ui.colorpicker-rgbslider.js
Expand Up @@ -22,25 +22,28 @@
g: $('<div class="ui-colorpicker-slider"/>'),
b: $('<div class="ui-colorpicker-slider"/>')
};

this.updateGradients = function () {
var color = inst.color.getRGB();

setGradient(sliders.r, new $.colorpicker.Color(0, color.g, color.b), new $.colorpicker.Color(1, color.g, color.b));
setGradient(sliders.g, new $.colorpicker.Color(color.r, 0, color.b), new $.colorpicker.Color(color.r, 1, color.b));
setGradient(sliders.b, new $.colorpicker.Color(color.r, color.g, 0), new $.colorpicker.Color(color.r, color.g, 1));
};

this.init = function () {
$('<div class="ui-colorpicker-rgbslider"/>').append(sliders.r, sliders.g, sliders.b)
.appendTo($('.ui-colorpicker-rgbslider-container', inst.dialog));

function refresh() {
var min,
max,
r = sliders.r.slider('value') / 255,
var r = sliders.r.slider('value') / 255,
g = sliders.g.slider('value') / 255,
b = sliders.b.slider('value') / 255;

inst.color.setRGB(r, g, b);

setGradient(sliders.r, new $.colorpicker.Color(0, g, b), new $.colorpicker.Color(1, g, b));
setGradient(sliders.g, new $.colorpicker.Color(r, 0, b), new $.colorpicker.Color(r, 1, b));
setGradient(sliders.b, new $.colorpicker.Color(r, g, 0), new $.colorpicker.Color(r, g, 1));

inst._change();

that.updateGradients();
}

$(sliders.r).add(sliders.g).add(sliders.b).slider({
Expand All @@ -50,6 +53,8 @@
slide: refresh,
change: refresh
});

this.updateGradients();
};

this.repaint = function () {
Expand Down

0 comments on commit 39c1d77

Please sign in to comment.