Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Fix deprecations on django 1.11 #318

Merged
merged 1 commit into from
Jul 16, 2017
Merged

Fix deprecations on django 1.11 #318

merged 1 commit into from
Jul 16, 2017

Conversation

bertonha
Copy link

@bertonha bertonha commented May 30, 2017

This also makes it incompatible with django < 1.8

@erickwilder
Copy link

You need to update version dependencies on setup.py as well

@erickwilder
Copy link

Since this is removing support for older Python/Django versions I would bump a major version here https://github.com/vandersonmota/model_mommy/blob/master/model_mommy/__init__.py

Suggestion: 2.0.0

@bertonha
Copy link
Author

bertonha commented Jun 7, 2017

@erickwilder I will leave this for the @vandersonmota, since the bump of version is out of scope of this PR

@erickwilder
Copy link

Fair enough 🎉 LGTM then

.travis.yml Outdated
env:
- DJANGO=django16
- DJANGO=django17
- DJANGO=django18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Django 1.8 is an LTS release (scheduled for deprecation in April 2018), I think support should be kept for it. The only thing that I think would need to be changed is something like this around the rel vs remote_field changes.

e.g.

...
remote_field = 'remote_field' if django.VERSION >= (1, 9) else 'rel'
if isinstance(field, OneToOneField) and getattr(field, remote_field).parent_link:
              return True
...

@ownaginatious
Copy link
Contributor

@bertonha cool, LGTM 👍 @vandersonmota please take a look :)

@vandersonmota
Copy link
Collaborator

@berinhard can you take a look at this?

@berinhard
Copy link
Owner

I'm travelling on vacations @vandersonmota with limited access to internet =/

@vandersonmota
Copy link
Collaborator

@bertonha can you make this PR against the development branch?

@vandersonmota
Copy link
Collaborator

Ah, BTW @bertonha Thanks!

@bertonha bertonha changed the base branch from master to development June 27, 2017 15:59
@ownaginatious
Copy link
Contributor

@vandersonmota seems @bertonha has changed the base to development per your feedback :)

@pedrospdc
Copy link

Can we get this merged? This PR is over a month already :(

@vandersonmota
Copy link
Collaborator

@pedrospdc sorry, i was dedicating free time for myself and family lately. I'll make sure this doesn't happen in the future.

@vandersonmota vandersonmota merged commit 4600303 into berinhard:development Jul 16, 2017
@vandersonmota
Copy link
Collaborator

thanks @bertonha

@ownaginatious
Copy link
Contributor

@vandersonmota thanks for merging. Could you push a new version to PyPI too?

@ownaginatious
Copy link
Contributor

@berinhard @vandersonmota PyPI push?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants