-
Notifications
You must be signed in to change notification settings - Fork 141
Fix deprecations on django 1.11 #318
Fix deprecations on django 1.11 #318
Conversation
You need to update version dependencies on |
Since this is removing support for older Python/Django versions I would bump a major version here https://github.com/vandersonmota/model_mommy/blob/master/model_mommy/__init__.py Suggestion: |
@erickwilder I will leave this for the @vandersonmota, since the bump of version is out of scope of this PR |
Fair enough 🎉 LGTM then |
.travis.yml
Outdated
env: | ||
- DJANGO=django16 | ||
- DJANGO=django17 | ||
- DJANGO=django18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that Django 1.8 is an LTS release (scheduled for deprecation in April 2018), I think support should be kept for it. The only thing that I think would need to be changed is something like this around the rel
vs remote_field
changes.
e.g.
...
remote_field = 'remote_field' if django.VERSION >= (1, 9) else 'rel'
if isinstance(field, OneToOneField) and getattr(field, remote_field).parent_link:
return True
...
@bertonha cool, LGTM 👍 @vandersonmota please take a look :) |
@berinhard can you take a look at this? |
I'm travelling on vacations @vandersonmota with limited access to internet =/ |
@bertonha can you make this PR against the |
Ah, BTW @bertonha Thanks! |
@vandersonmota seems @bertonha has changed the base to |
Can we get this merged? This PR is over a month already :( |
@pedrospdc sorry, i was dedicating free time for myself and family lately. I'll make sure this doesn't happen in the future. |
thanks @bertonha |
@vandersonmota thanks for merging. Could you push a new version to PyPI too? |
@berinhard @vandersonmota PyPI push? |
This also makes it incompatible with django < 1.8