Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync of multiple locations doesn't match current subscriptions #2

Closed
vaneenige opened this issue Apr 29, 2017 · 1 comment
Closed

Comments

@vaneenige
Copy link
Owner

When the application is loaded or the user presses the sync button the latest weather information from the added locations is fetched from the server. Once this is done the new locations are merged with the old locations to manage the local subscriptions accordingly.

The issue here is that sometimes locations from the server are not in the same order of those on the client. This could result in locations and subscriptions not matching after syncing them with the latest data.

@vaneenige
Copy link
Owner Author

This issue has been resolved in the following commit: b6929d8 🎉

Locations and subscriptions are now synced based on their name instead of order. Besides this locations in the list (on add and sync) are also in chronological order.

Note: If you experience the issue above from locations and subscriptions added before this update, removing the locations and adding them again should fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant