Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip safe? #19

Closed
vaneseltine opened this issue Sep 12, 2019 · 4 comments
Closed

zip safe? #19

vaneseltine opened this issue Sep 12, 2019 · 4 comments
Labels
Milestone

Comments

@vaneseltine
Copy link
Owner

Yea or nay?

@vaneseltine vaneseltine added this to the 1.0 milestone Sep 12, 2019
@vaneseltine
Copy link
Owner Author

Currently, this analysis is extremely conservative: it will consider the project unsafe if it contains any C extensions or datafiles whatsoever. This does not mean that the project can't or won't work as a zipfile! It just means that the bdist_egg authors aren't yet comfortable asserting that the project will work. If the project contains no C or data files, and does no file or path introspection or source code manipulation, then there is an extremely solid chance the project will work when installed as a zipfile. (And if the project uses pkg_resources for all its data file access, then C extensions and other data files shouldn't be a problem at all. See the Accessing Data Files at Runtime section above for more information.)

@vaneseltine
Copy link
Owner Author

So it matters for the Python package being able to:

  1. find examples (if we care about those in package)
  2. connect those examples to their data (but it wouldn't make much sense to use those dirs anyway)
  3. finding test data (but that shouldn't matter for the package)

Therefore make this dependent on #23

@vaneseltine
Copy link
Owner Author

vaneseltine added a commit that referenced this issue Sep 13, 2019
@vaneseltine
Copy link
Owner Author

Spun off examples into https://github.com/vaneseltine/nominally-examples

Accordingly, removed any need here for introspection and path handling from installed package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant