Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: gimme_motifs call ignores user specified args #177

Closed
kirbyziegler opened this issue Mar 20, 2021 · 0 comments
Closed

FIX: gimme_motifs call ignores user specified args #177

kirbyziegler opened this issue Mar 20, 2021 · 0 comments
Milestone

Comments

@kirbyziegler
Copy link

kirbyziegler commented Mar 20, 2021

Issue: user defined arguments are not included in gimme_motifs() in motifs.py line 104

gimme_motifs(
            sample,
            args.outdir,
            params={
                "tools": args.tools,
                "analysis": args.analysis,
                "background": bg,
                "custom_background": bgfile,
                "genome": args.genome,
                "size": args.size,
            },
        )

As a result:
params = parse_denovo_params(params) in denovo.py line 571 sets parameters to default
prepare_denovo_input_bed() uses default fraction and abs_max (ignoring user-defined fraction value)

Easy fix options:

(1) set the .config/gimmemotifs/gimmemotifs.cfg file directly

OR

(2) alter gimme_motifs() in motifs.py line 104:

gimme_motifs(
            sample,
            args.outdir,
            params={
                "tools": args.tools,
                "analysis": args.analysis,
                "background": bg,
                "custom_background": bgfile,
                "genome": args.genome,
                "size": args.size,
                "fraction": args.fraction,
            },
        )
@kirbyziegler kirbyziegler changed the title gimme_motifs call ignores user specified args FIX: gimme_motifs call ignores user specified args Mar 24, 2021
@simonvh simonvh added this to the 0.15.4 milestone Apr 13, 2021
@simonvh simonvh closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants