Optimize RPS #77
Merged
Optimize RPS #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor random string
Add assets helper
Tienisto
reviewed
Jun 16, 2024
| @@ -13,6 +13,7 @@ class DatabaseClient { | |||
| database = await MysqlDriver().init(); | |||
| database?.connection.reconnectIfMissingConnection(); | |||
| break; | |||
| case 'postgressql': | |||
There was a problem hiding this comment.
This is a typo and should not be promoted. It is better to at least log a warning so that this typo gets fixed by the developer.
There was a problem hiding this comment.
Fixed Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and optimize the Controller handler
Refactor request handler
Refactor Request class
Add none to response type and await for res close
Refactor route handler
export database client
Add URL helper
Add assets helper