Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next-plugin): url statements in vanilla css would not respect next's setup for resolving assets #1155

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

GeeWizWow
Copy link
Contributor

Fixes #1154, adds parity with next for the css-loader url and import options, by leveraging next's logic.

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023

🦋 Changeset detected

Latest commit: 8bbebe2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vanilla-extract/next-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IngoValente
Copy link

Would love to see this get merged!

@GeeWizWow
Copy link
Contributor Author

Would love to see this get merged!

If it helps, I've added a patch you can use in #1154

Copy link
Contributor

@mattcompiles mattcompiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🍻

@mattcompiles mattcompiles enabled auto-merge (squash) August 9, 2023 22:17
@mattcompiles mattcompiles merged commit 1cb537b into vanilla-extract-css:master Aug 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@vanilla-extract/next-plugin] css-loader url option not respected
3 participants