Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite-plugin: Whitelist vite-plugin-svelte #952

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

endigma
Copy link
Contributor

@endigma endigma commented Dec 21, 2022

  • Add explicit exception for when plugins includes vite-plugin-svelte.
  • Add a user configurable override

Resolves #937

I'm not sure how this plays into #851, that PR seems dead/invalid?

This fixes SSR support in sveltekit, at least, and provides an override for other framework users to use before built-in support is added.

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2022

🦋 Changeset detected

Latest commit: 73b8f17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vanilla-extract/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@astahmer
Copy link

FWIW I also added an option for forceEmitCssiInSsrBuild here, which show it's needed

@endigma
Copy link
Contributor Author

endigma commented Dec 21, 2022

FWIW I also added an option for forceEmitCssiInSsrBuild here, which show it's needed

Nice, I do disagree with you about "would probably allow removing the hard-coded checks", the point of these is to reduce friction in cases where it's definitely required. This is good DX.

Let's home something gets merged soon.

@astahmer
Copy link

ah yes you're right, it makes sense for the DX !

@endigma
Copy link
Contributor Author

endigma commented Dec 28, 2022

What does this need to be merged?

@endigma
Copy link
Contributor Author

endigma commented Jan 13, 2023

@michaeltaranto @mattcompiles @markdalgleish

What needs to be done here? This fixes VE usage for SvelteKit and probably others. VE is practically unusable on non-whitelisted frameworks right now as SSR FOUC is a problem.

@michaeltaranto michaeltaranto changed the title vite-plugin: Whitelist vite-plugin-svelte and make forceEmitCssiInSsrBuild configurable. vite-plugin: Whitelist vite-plugin-svelte Jan 23, 2023
@michaeltaranto
Copy link
Contributor

Discussed this one at the maintainers meeting this morning and we are going to split this into two so we can get sveltekit out the door. We will look at adding the forceSSR flag in a separate PR along with documentation.

@michaeltaranto michaeltaranto enabled auto-merge (squash) January 23, 2023 01:03
@michaeltaranto michaeltaranto merged commit a677c46 into vanilla-extract-css:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect classnames during SSR
3 participants