Delete commons submodule and use library implementation (jitpack) #12
Conversation
TacoTheDank
changed the title
app/build.gradle
Outdated
| @@ -50,5 +51,5 @@ play { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation project(':plugin-commons') | |||
| implementation 'com.github.vanilla-music:vanilla-music-plugin-commons:v1.0.0' | |||
There was a problem hiding this comment.
It's 1.0.0, without "v". Sorry, all other plugins follow same scheme, can't change it for one library.
app/build.gradle
Outdated
| release { | ||
| zipAlignEnabled true | ||
| minifyEnabled true |
There was a problem hiding this comment.
What does this do? This won't enable proguard, will it?
There was a problem hiding this comment.
minifyEnabled will, but zipAlignEnabled isn't needed because it's already set to true for release builds by default.
There was a problem hiding this comment.
The thing is, I never tested this plugin with proguard, can you add useProguard false then?
There was a problem hiding this comment.
Uhh sure, I can also just set minifyEnabled false for now.
app/build.gradle
Outdated
| @@ -3,13 +3,14 @@ apply plugin: 'com.github.triplet.play' | |||
|
|
|||
| android { | |||
| compileSdkVersion 28 | |||
| buildToolsVersion '28.0.3' | |||
There was a problem hiding this comment.
Not required. Without this it'll take latest one for compile sdk, which is what we need
| @@ -242,10 +242,10 @@ public boolean onOptionsItemSelected(MenuItem item) { | |||
| * extras from artwork response (if found) or with original intent | |||
| * </pre> | |||
| */ | |||
| private static boolean pluginInstalled(Context ctx, String pkgName) { | |||
| private static boolean pluginInstalled(Context ctx) { | |||
There was a problem hiding this comment.
Nope, this will add confusion. This function can possibly be reused for other plugins, so please leave it as it was.
Signed-off-by: Taco <SkytkRSfan3895@gmail.com>
|
@Adonai was able to get around to it |
|
Looks good to me, not sure why Travis doesn't like you. |
|
Travis never did like me much lol |
Signed-off-by: Taco SkytkRSfan3895@gmail.com