New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exceptions by adding request/response context and json_serialize support #32

Merged

charrondev merged 2 commits into master from feature/better-exceptions

Sep 8, 2023

Contributor

charrondev commented Sep 7, 2023

This PR improves our exceptions in garden-http by doing the following:

Exceptions now extends Garden\Utils\ContextException.
Exceptions now have request and response data in the their context and implement JsonSerialize
Exceptions now have have their request path, method and response code in their message.
Request and Response now implement JsonSerialize

charrondev added 2 commits

September 7, 2023 13:24


          Improve http exceptions and json serialization

b42820c


          Add tests for exception serialization

5c31ca7

charrondev merged commit b3990ad into master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment