Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multisiteIDs - VNLA-4485 #3

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Add support for multisiteIDs - VNLA-4485 #3

merged 2 commits into from
Dec 6, 2023

Conversation

acharron-hl
Copy link
Contributor

https://higherlogic.atlassian.net/browse/VNLA-4485

This PR adds some additional functionality and support into the site providers in order to support the new search service.

Changes

  • Add Site::getMultisiteID(): int method.
    • For localhost this is generated automatically based off of the sites hostname.
  • Add SiteProvider::getSitesByMultisiteID(): array method.
  • Add SiteProvider::getSitesByAccountID(): array method.
  • Add tests for these methods.

@acharron-hl acharron-hl requested a review from a team December 6, 2023 22:40
vanilla-dbarbier
vanilla-dbarbier approved these changes Dec 6, 2023
View reviewed changes
Copy link

@vanilla-dbarbier vanilla-dbarbier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.
I would however add a docblock description to the 2 new tests.

@acharron-hl acharron-hl merged commit 3d30428 into main Dec 6, 2023
9 checks passed
@acharron-hl acharron-hl deleted the feature/mutlisiteid-support branch December 6, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanilla-dbarbier vanilla-dbarbier vanilla-dbarbier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@acharron-hl @vanilla-dbarbier