Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive function doesn't exclude threads from the bookmark counter #2894

Closed
LauraMakesArt opened this issue Jul 15, 2015 · 0 comments · Fixed by #9488
Closed

Archive function doesn't exclude threads from the bookmark counter #2894

LauraMakesArt opened this issue Jul 15, 2015 · 0 comments · Fixed by #9488
Labels
Domain: Discussions Status: PR This issue has a PR ready. It's not necessary to use this label, but can be helpful. Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible.

Comments

@LauraMakesArt
Copy link

LauraMakesArt commented Jul 15, 2015 •
edited by charrondev

Currently, the Bookmark counter counts archived discussions. This is problematic as the bookmark page does not display the archived discussions, which can lead to an incorrect count of bookmarked discussions. Further, the pagination seems based on this count, so even if only five bookmarked discussions are displayed, if there are another 50 bookmarked discussions that are archived, pagination will allow for enough pages to display the total of 55 bookmarked discussions.

  • Expected behaviour:Bookmark counter ignores archived discussions
  • Pagination on bookmark page ignores archived discussions

Reproduction Steps

  1. Create "Category A"
  2. Create "Discussion 1" in "Category A"
  3. Take note of current user's bookmark count.
  4. Bookmark "Discussion 1"
  5. Notice that bookmark counter goes up by 1.
  6. Archive "Category A"

Expected

Bookmark counter goes down by 1.

Actual

Bookmark counter stays the same.
@charrondev charrondev added the Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible. label Jan 3, 2019
@charrondev charrondev mentioned this issue Jan 3, 2019
Closed
tburry added a commit that referenced this issue Oct 24, 2019
@tburry
Remove discussion archiving
09dbd50 
Discussion archiving has been unsupported and hidden for some time now. This removes it altogether as we are unlikely to be able to properly support it.

Closes #5294.
Closes #5206.
Closes #2894.
Closes #3870.
This was referenced Oct 24, 2019
Closed
Merged
@tburry tburry added the Status: PR This issue has a PR ready. It's not necessary to use this label, but can be helpful. label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: Discussions Status: PR This issue has a PR ready. It's not necessary to use this label, but can be helpful. Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible.
Projects
None yet
Milestone
No milestone
3 participants
@tburry @charrondev @LauraMakesArt