Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function reactionButton() is used but not defined. #5324

Closed
R-J opened this issue Mar 17, 2017 · 2 comments
Closed

Function reactionButton() is used but not defined. #5324

R-J opened this issue Mar 17, 2017 · 2 comments
Labels
Status: Stale For stale issues that will be automatically closed. Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible.

Comments

@R-J
Copy link
Contributor

R-J commented Mar 17, 2017

https://github.com/vanilla/vanilla/blob/master/library/core/functions.render.php#L1616

I assume that function is defined as part of the closed source reactions addon.

Since rendering reactions is part of the OS version, too, I would expect to see such a function in functions.render.php.

@charrondev
Copy link
Contributor

Permalink here

echo '<li>'.reactionButton($row, $flag['UrlCode']).'</li>';

@charrondev charrondev added the Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible. label Jan 28, 2019
@stale
Copy link

stale bot commented Jan 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale For stale issues that will be automatically closed. label Jan 28, 2020
@stale stale bot closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale For stale issues that will be automatically closed. Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible.
Projects
None yet
Development

No branches or pull requests

2 participants