Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdn_SQLDriver::noReset fails to set class property #5428

Closed
dafriend opened this issue Apr 12, 2017 · 1 comment
Closed

Gdn_SQLDriver::noReset fails to set class property #5428

dafriend opened this issue Apr 12, 2017 · 1 comment
Labels
Domain: Database Status: Stale For stale issues that will be automatically closed. Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible.

Comments

@dafriend
Copy link

dafriend commented Apr 12, 2017

Vanilla version 2.3
This line of code in the method noReset is setting a local variable and not the intended class property.

$_NoReset = $NoReset ? ($OneTime ? 1 : 2) : 0;

The effect will be that the method reset() will always reset all the class properties. In other words, the method noReset() has no effect on the class.

The code should be $this->_NoReset = $NoReset ? ($OneTime ? 1 : 2) : 0;

@charrondev charrondev added Domain: Database Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible. labels Jan 3, 2019
@stale
Copy link

stale bot commented Jan 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale For stale issues that will be automatically closed. label Jan 3, 2020
@stale stale bot closed this as completed Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Database Status: Stale For stale issues that will be automatically closed. Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible.
Projects
None yet
Development

No branches or pull requests

2 participants