Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting parent category and assigning a child as its replacement creates phantom category. #6535

Closed
JReko opened this issue Jan 26, 2018 · 3 comments
Labels
Domain: Categories Status: Stale For stale issues that will be automatically closed. Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible.

Comments

@JReko
Copy link
Contributor

JReko commented Jan 26, 2018

For example:

  • Category 1
  • Category 2
  • Category 3
    • Category 4

Deleting category 3 and selecting category 4 as its replacement will delete category 3 and make category 4 disappear. Reason is simple. Category 4 now has its own ID as a ParentCategoryID.

Solution could be fixing the attribution of the ParentCategoryID or preventing child categories from being a replacement option when we delete a parent category.

@charrondev charrondev added Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible. Domain: Categories labels Mar 5, 2019
@stale
Copy link

stale bot commented Mar 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale For stale issues that will be automatically closed. label Mar 4, 2020
@JReko
Copy link
Contributor Author

JReko commented Mar 4, 2020

I'm removing the stale label on this one, until someone explicitly says we don't want to fix it. Granted it's probably low on priority but this bug can/will probably lead to awful user experience, support tickets, support investigations, dev investigations, dev manual database fixes. The scope is fairly small and a short amount of time would be spent fixing it. Balancing out the cost of fixing it versus the cost of the bug happening the a few times, I think we already win.

@stale stale bot removed the Status: Stale For stale issues that will be automatically closed. label Mar 4, 2020
@stale
Copy link

stale bot commented Mar 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale For stale issues that will be automatically closed. label Mar 5, 2021
@stale stale bot closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Categories Status: Stale For stale issues that will be automatically closed. Type: Bug A clear defect in a feature that has been shipped. Fix should include automated testing if possible.
Projects
None yet
Development

No branches or pull requests

2 participants