Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing and reactions alignment in Keystone/Boilerplate #10029

Merged
merged 1 commit into from Feb 4, 2020

Conversation

igraziatto
Copy link
Contributor

@igraziatto igraziatto commented Feb 3, 2020

@igraziatto igraziatto requested review from a team and cchabilall83 and removed request for a team February 3, 2020 20:21
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #10029 into master will decrease coverage by 24.44%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #10029       +/-   ##
=============================================
- Coverage     52.51%   28.06%   -24.45%     
+ Complexity     7854     4834     -3020     
=============================================
  Files           367      170      -197     
  Lines         43934    32189    -11745     
=============================================
- Hits          23070     9034    -14036     
- Misses        20864    23155     +2291
Impacted Files Coverage Δ Complexity Δ
library/Vanilla/Formatting/Quill/Renderer.php 0% <0%> (-100%) 0% <0%> (ø)
...ry/Vanilla/Authenticator/PasswordAuthenticator.php 0% <0%> (-100%) 11% <0%> (ø)
library/Garden/StaticCacheConfigTrait.php 0% <0%> (-100%) 0% <0%> (ø)
...ions/dashboard/library/class.staticinitializer.php 0% <0%> (-100%) 2% <0%> (ø)
library/Garden/StaticCacheTranslationTrait.php 0% <0%> (-100%) 0% <0%> (ø)
library/Vanilla/Utility/CapitalCaseScheme.php 0% <0%> (-100%) 1% <0%> (ø)
library/Vanilla/Site/DefaultSiteSection.php 0% <0%> (-100%) 8% <0%> (+1%)
library/Vanilla/AliasLoader.php 0% <0%> (-100%) 0% <0%> (ø)
library/Garden/MetaTrait.php 0% <0%> (-96.88%) 14% <0%> (ø)
library/Vanilla/Web/TwigRenderTrait.php 0% <0%> (-95.66%) 0% <0%> (ø)
... and 305 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c896c49...4892900. Read the comment docs.

@igraziatto igraziatto requested review from a team, charrondev and cchabilall83 and removed request for cchabilall83 and a team February 3, 2020 20:31
@blutarch blutarch requested review from blutarch and danni-stark and removed request for charrondev and cchabilall83 February 4, 2020 15:07
Copy link
Member

@blutarch blutarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified visually on localhost that all the linked issues are resolved by the PR.

@igraziatto igraziatto merged commit 926c665 into master Feb 4, 2020
@charrondev charrondev deleted the fix/boilerplate-theme-styles branch February 4, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants