Accessibility Improvements - labels, IDs, colours, heading order, tab indexes #10743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
June 8, 2020 06:39
…e-color-contrast * feature/refactor-color-helper-props: Refactored props of modifyColorBasedOnLightness to use an object instead of multiple params
* master: Replace regex for sprintf Removed unecessary references to activity name and made it optional Implemented feedback Refactored parsing of images Fixing unit test Fixed translation and linting errors Add translation function to gdn object Fixed label for options dropdown and fixed broken link text Fixed bad tab indexes Fixed visibility of alt text for options dropdowns Fixed missing description for mounted Editors Added missing text to button Added new function to formatters to fetch the alt text from images in the search results. Added label to token input Added aria-hidden on autosize Fix duplicate IDs for atwho plugin Replaced nav tag for div Add missing text to mebox close button Fixed accessibility issues for flyouts and user images Fixing image alt texts Fixing flyout IDs
…, removed dead code, scrollable code
* master: (51 commits) Rollback flyouts touchstart event change Fix bad test Normalize unicode in URL paths before scraping tweak tweak tweak sinc themes with master fix keystone styles fix drafts count Fix normalization of current theme when Garden.CurrentTheme isn't set update docblock use invalidargumentexception fix lint exception message add exception if wrong type is provided test if expcetionType exists before adding to exception array Fix forum breadcrumbs in hub/node sites Tweak the name of ArrayUtils::mergeRecursive adjust spacing add a blockexcpetion method to the dispatcher ... # Conflicts: # library/src/scripts/headers/mebox/pieces/TitleBarNavItem.tsx
slafleche
changed the title
Codecov Report
@@ Coverage Diff @@
## master #10743 +/- ##
============================================
- Coverage 56.64% 56.61% -0.04%
+ Complexity 7497 3942 -3555
============================================
Files 398 398
Lines 45528 45503 -25
============================================
- Hits 25791 25761 -30
- Misses 19737 19742 +5
|
charrondev
suggested changes
Jun 10, 2020
applications/dashboard/src/scripts/compatibilityStyles/blockColumnStyles.ts
Outdated
Show resolved
Hide resolved
…lumnStyles.ts Co-authored-by: Adam Charron <adam@charrondev.com>
cchabilall83
approved these changes
Jun 10, 2020
charrondev
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various accessibility issues:
clickableItemStatesit had dead code and dead propsCloses: https://github.com/vanilla/internal/issues/2555