Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextBoxes Content in ThemeOptions #2990

Merged
merged 1 commit into from Aug 20, 2015
Merged

Fix TextBoxes Content in ThemeOptions #2990

merged 1 commit into from Aug 20, 2015

Conversation

R-J
Copy link
Contributor

@R-J R-J commented Aug 20, 2015

TextBoxes in ThemeOptions have always been empty, regardless of their config value. The reason is that the value has been set to the form, but not to forms $_DataArray.

Thanks to ThemeSteam who spotted this misbehavior!

For anyone interested in this: you can create text inputs in your theme options quite easily (in themes about.php)

$ThemeInfo['SomeTheme'] = array(
    // ...
    'Options' => array(
        'Text' => array(
            'PanelPosition' => array(
                'Default' => 'left',
                'Description' => 'Please choose between "left", "right", or "none"',
                'Type' => 'TextBox'
            )
        )
    ),
    // ...

Afterwards you can access such a setting with c('ThemeOption.PanelPosition')

TextBoxes in ThemeOptions have always been empty, regardless of their config value. The reason is that the value has been set to the form, but not to forms $_DataArray.
@linc
Copy link
Contributor

linc commented Aug 20, 2015

Great debug!

linc added a commit that referenced this pull request Aug 20, 2015
Fix TextBoxes Content in ThemeOptions
@linc linc merged commit ab8feb4 into vanilla:master Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants