Make resource routes whitelist instead of blacklist #5328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tburry
force-pushed
the
feature/resource-route-whitelist
branch
from
99b7787
to
43055de
Compare
initvector
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource router was blacklisting methods with an isProtected method just like the old router. This was a mistake in the old router and we shouldn’t make the same mistake again.
Now we will use a whitelist so that methods will not be accessible as an endpoint unless they meet the following criteria.
index.<HTTP method>_name.The resource router will not map methods like the current router. This means that the resource router will not be used for current Vanilla controllers. The intention is that when we want to update our HTML app then we will move the controllers over one-by-one.