Fix entry/connect AJAX errors (Backport) #8919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues with AJAX handling. - A code path validated the transient key rather than checking for an authenticated postback. Now that postbacks have a looser validation that is only afforded for in `Gdn_Request::isAuthenticatedPostback()`. - A code path used form validation to check to see if a value was empty. This was causing the error to be added to the validation results as a side effect, resulting in the form failing. Before AJAX this was okay because validation results did not cancel a redirect. After AJAX they do.
charrondev
approved these changes
Jun 10, 2019
linc
deleted the
backport/349ef8b5a7043da3b83b15780eda81dc377ba46a-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues with AJAX handling.
Gdn_Request::isAuthenticatedPostback().