Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect editor selection handling #8967

Merged
merged 1 commit into from Jun 17, 2019
Merged

Fix incorrect editor selection handling #8967

merged 1 commit into from Jun 17, 2019

Conversation

charrondev
Copy link
Contributor

Fixes #8957

Some recent refactoring introduced a bug where certain editor events were not being properly tracked.

This is fixed by 2 things:

  1. Tracking the EDITOR_CHANGE event instead of the selection-change event.
  2. Initializing the synchronization handler when first mounting the editor.

@charrondev charrondev mentioned this pull request Jun 17, 2019
Closed
@initvector initvector merged commit 3f9c29c into master Jun 17, 2019
@tburry tburry mentioned this pull request Jun 20, 2019
Merged
@linc linc deleted the fix/wrong-editor-selection branch September 21, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@initvector initvector initvector approved these changes

@slafleche slafleche slafleche approved these changes

Assignees

@initvector initvector

@slafleche slafleche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rich Editor: When pasting an image it positions it above the text
3 participants
@charrondev @initvector @slafleche