Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old redux utilities and refactor auth pages #9800

Merged
merged 1 commit into from Dec 10, 2019

Conversation

charrondev
Copy link
Contributor

@charrondev charrondev commented Dec 10, 2019

Closes #7952

  • Deletes @libary/redux/utility
  • Refactors the only components using them, the shelved, feature-flagged, auth pages.
    • Now uses functional components.
    • Now use hooks.
    • Now has a single unified reducer.
    • Now uses the new action class, and FSA actions.
    • Preloads authenticator data properly.
    • Fixed error handling which was not functioning correctly.
  • KB has 1 import to update as well, that can be found here https://github.com/vanilla/knowledge/pull/1452

Testing

To see the auth pages:

  1. Add the following line to your config.
$Configuration['Feature']['AuthenticationAPI']['Enabled'] = true;
  1. Go to /authenticate on your local site.
  2. Login & password reset are the only implemented features.

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #9800 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #9800     +/-   ##
===========================================
  Coverage     50.77%   50.77%             
- Complexity     3670     7686   +4016     
===========================================
  Files           342      342             
  Lines         42511    42511             
===========================================
  Hits          21587    21587             
  Misses        20924    20924

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dece1e...ef06422. Read the comment docs.

@slafleche slafleche merged commit 436a65a into master Dec 10, 2019
@slafleche slafleche deleted the refactor/authenticate-page branch December 10, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old redux utility methods
3 participants