Display categories with no discussions on "Mixed" layout #9938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9938 +/- ##
===========================================
Coverage 52.28% 52.28%
+ Complexity 7801 3764 -4037
===========================================
Files 361 361
Lines 43671 43671
===========================================
Hits 22834 22834
Misses 20837 20837Continue to review full report at Codecov.
|
tburry
suggested changes
Jan 16, 2020
tburry
suggested changes
Jan 17, 2020
|
|
||
| <?php endforeach; ?> | ||
| <?php else: ?> | ||
| <div class="Empty"><?php echo t('No categories were found.'); ?></div> | ||
| <?php else: |
There was a problem hiding this comment.
This seems wrong. You are outside of your loop. It seems like you still need that "No categories were found" from above.
tburry
approved these changes
Jan 20, 2020
charrondev
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/vanilla/support/issues/275
The issue It's not keystone related actually, it's just how this view works (disable the theme and you will see the same behavior).
The view doesn't render categories who have no discussions. Since you can't add discussions to categories type "Nested", it ignores them:
vanilla/applications/vanilla/views/categories/discussions.php
Line 17 in 9dda0f3
Notes: The view seems to flat the category tree when rendering so I've just followed the same logic.