New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert logic to validate empty string where the default is not null #9981
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9981 +/- ##
============================================
- Coverage 52.29% 52.27% -0.03%
- Complexity 3766 7806 +4040
============================================
Files 362 362
Lines 43849 43818 -31
============================================
- Hits 22931 22905 -26
+ Misses 20918 20913 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 99% done. Two small issues.
Please make sure these points are completed:
Along with vanilla/internal#2197, this will close issue vanilla/support#1239
The updated comboBreaker data was not being saved to the db.
Because the badge status was an empty string and didn't have a default value of null, it was not passing validation. This fix adds logic to validateRequired() in functions.validation that allows it to pass validation.
To Test: