Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change operators with Object.entries to use Object.keys to improve cross browser compatibility #205

Closed
jkvyff opened this issue Jan 12, 2020 · 1 comment

Comments

@jkvyff
Copy link
Collaborator

jkvyff commented Jan 12, 2020

As you pointed out, Object.entries is not supported by internet explorer.

All methods using Object.Entries should be able to be reworked to use Object.keys, do you see any downsides?

References

@jkvyff jkvyff changed the title Change operators with Object.entries to use Object.keys to stay strengthen cross browser compatibility Change operators with Object.entries to use Object.keys to improve cross browser compatibility Jan 12, 2020
@evanplaice
Copy link
Member

All methods using Object.Entries should be able to be reworked to use Object.keys, do you see any downsides?

No. When this project started, IE support wasn't really considered. Now that I've spent many hours digging through documentation to plan the scope, I think adding 'ie polyfill' as a selling point will be good to attract users.

Since this change is non-breaking, lets table it until after the 1.0 release.

@evanplaice evanplaice mentioned this issue Jan 13, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants