ItPropFit.jl v0.2.0: Multidimensional array margins #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per Agresti, sec. 9.7.2
- ArrayDims are now DimIndex (should maybe be DimIndices?)
- add uniqueness check - add docs - update issorted method
- Fix reference to DimIndices in docs - Add size method - Remove buggy sorting stuff
- Find failure - remove weird sorting code
- Now works with arbitrary DimIndices - Fixed the size method - Also fixed the size method for ArrayMargins
- add DimIndices tests - add ArrayMargins tests - overhaul ArrayFactors tests
- also add getindex method for dimindices
- also update to julia 1.8.0
preparation for #6
- remove original ipf - add convenience interface for new ipf - adjust tests - move consistency tests to ArrayMargins
- Add consistency checks to test - Add margin transform to export - Fix small bug with inconsistent margin info message
The new algorithm is quite a bit faster!
- Move getdims to default_dimindices in DimIndices file - Adjust tests for new constructor setup
For cleaner test output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big overhaul of the API, but maintaining some of the ease-of-use / qol interface of v0.1.0.
Fixes #4