Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a visualize parm for the ask function #160

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Conversation

relic-yuexi
Copy link
Contributor

Sometimes we don't need visualize the data. And by saving the token usage when we are testing some question, it's wise to close the visualize the data.

@relic-yuexi
Copy link
Contributor Author

The error message you're seeing is due to the use of the list type hint in Python 3.8. The list type hint was introduced in Python 3.9, so it's not available in Python 3.8.

In Python 3.8, you should use List from the typing module instead. Here's how you can modify your code:

from typing import List

class VannaBase(ABC):
   # ...
   def generate_questions(self, **kwargs) -> List[str]:
       pass

@zainhoda
Copy link
Contributor

Thank you so much for submitting this! I will review and merge in a few hours

MoonTidef added 3 commits January 19, 2024 13:55
This commit refactors the initialization of the ChromaDB_VectorStore class in the chromadb_vector.py file. The code now uses the "config.get" method to handle the "path" and "embedding_function" parameters. This change improves code readability and maintainability.
@zainhoda zainhoda self-requested a review January 22, 2024 01:05
@zainhoda zainhoda merged commit 38d7239 into vanna-ai:main Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants