Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue templates #224

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Issue templates #224

merged 4 commits into from
Feb 13, 2024

Conversation

andreped
Copy link
Contributor

This PR fixes issue #223.

CIs are not required for this PR, so I added [no ci] for all commits.

@andreped
Copy link
Contributor Author

andreped commented Feb 7, 2024

Any comments regarding adding these issue templates, @NickCrews?

Feel free to suggest corrections/improvements :]

At least I think having this would increase the user friendliness for new users/contributors.

@NickCrews
Copy link

those look good! Can always edit them if we find that people are giving bad reports due to the framework.

Potentially could add a vanna.show_versions() command, similar to pd.show_versions(), so that people are acually likely to fill it out, and we get all the env info we need, including other PyPI packages. But that could come later.

@andreped
Copy link
Contributor Author

andreped commented Feb 7, 2024

Potentially could add a vanna.show_versions() command [...]

Thats a cool idea. I guess it would make sense to tailor these templates based on what people might ask. This I am not really qualified for, as I have yet to use this framework nor know the user base.

However, by having these templates, maintainers should quickly note what people tend to add in addition to these templates (or if they remove sections in general), which then should give them some hints on how they could be refined.

@zainhoda zainhoda merged commit 242cf8d into vanna-ai:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants