Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterized the number of documentation documents to be retrieved #354

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

GiacomoPracucci
Copy link
Contributor

@GiacomoPracucci GiacomoPracucci commented Apr 11, 2024

I am working with ChromaDB with many small documentation documents and need to increase the number of retrieved documentation documents from the vectorstore.

it would be useful to also be able to parameterize the number of documentation documents to be retrieved from the vectorstore

fixes #353

@andreped
Copy link
Contributor

@GiacomoPracucci Can you add the "fixes #353" to the PR description. That way when this PR is merged, the issue will automatically be closed.

@zainhoda
Copy link
Contributor

Thanks @GiacomoPracucci !

@andreped I made some changes here -- the parameters are n_results_sql, n_results_documentation, and n_results_sql which if not present, back up to n_results, and then default to 10.

This gives the user the option to granularly set the n_results for each type or to set them all at once or to omit them. WDYT?

@andreped
Copy link
Contributor

@zainhoda LGTM :) Looking forward to testing this on Monday hopefully. Great job!

@zainhoda zainhoda merged commit 163bcf1 into vanna-ai:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants