singleLine and ellipsize

[0mar-ahmed]

When i set android:singleLine="true" to EmojiTextView
if the line contain emoji in the end of it show a part of this emoji after the ellipsize (...)

https://imgur.com/a/z631RHe

[vanniktech]

I don't quite follow.

[0mar-ahmed]

Hello Niklas

i am trying to set singleLine attribute to EmojiTextViews so if the text is more than one line it should truncate it to one line and add three dots in the end of line like this (...)
https://imgur.com/a/KkhxJmb

it's all fine when this text doesn't contain emojis
but when it has emojis in the end of the text a portion of the emoji appears after the three dots in the end
https://imgur.com/a/JSx9OAh

if you want test it yourself to get idea about it
add android:singleLine="true" to adapter_chat.xml
and try to type very long text that has emojis in the end

thanks

[vanniktech]

Ah I get it. Okay this can be possibly fixed.

[0mar-ahmed]

Great i would like to help fixing it but i don't know where exactly the problem
if you can tell me where to look i would love to send you a pull request

[vanniktech]

Somewhere in Emojis setText method

Emoji/emoji/src/main/java/com/vanniktech/emoji/EmojiTextView.java

Line 45 in 581ca50

@Override @CallSuper public void setText(final CharSequence rawText, final BufferType type) {

and the replaceWithImages method

Emoji/emoji/src/main/java/com/vanniktech/emoji/EmojiManager.java

Line 39 in 581ca50

@Override public void replaceWithImages(final Context context, final Spannable text, final float emojiSize, final float defaultEmojiSize, final EmojiReplacer fallback) {

[0mar-ahmed]

Hello Niklas

i didn't know which part exactly that should we should modify
actually i don't know why that Span appears anyway

should we stop add spans to the text if its position more the endline position ?

thanks

[vanniktech]

Dunno either as I'd investigate too.

[0mar-ahmed]

Hello Niklas

Any updates? i didn't find out something so far, wbu?

thanks

[vanniktech]

No haven't spend any time on it yet.

[vanniktech]

I'm closing this issue due to inactivity. If you have any further input on the issue, don't hesitate to reopen this issue or post a new one.

I won't get it to it in the near future. If someone else wants to, feel free to.

[nAkhmedov]

I am facing the same issue on 0.6.0 version, any news?

[mario]

I'll look into it.

[mario]

https://issuetracker.google.com/issues/36991688

Google issue. Let me see if it's trivial to workaround.

[KishoreBaktha]

Any progress on this?

[mario]

None, I am deciding on the best approach.

…

On Thu, 7 Nov 2019, 12:50 Kishore B, ***@***.***> wrote: Any progress on this? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#278?email_source=notifications&email_token=AAABNMSYOKAF4I6RFRHUMJTQSP6JVA5CNFSM4E4UVKXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDMFCUA#issuecomment-551047504>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABNMQRBMTAL6FAZAD5K4LQSP6JVANCNFSM4E4UVKXA> .

[KishoreBaktha]

Okay, please let me know when you have decided on the solution :)

[vanniktech]

@mario gentle push, can we solve this? If not, let's close

[mario]

We can, just I didn't have the time yet.

[vanniktech]

Not worth it in my opinion. Feel free to convince me though.