Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate smaller Emoji Chunks classes to avoid MethodTooLargeException #884

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

bmarty
Copy link
Contributor

@bmarty bmarty commented Aug 29, 2022

Attempt to fix #883. Note that 120 for chunk size is quite arbitrary, let's cross finger it will be enough.

I am not sure if I have to include the result of running yarn in the Pull Request (latest commit), happy to remove the commit if necessary.

Also including a small improvement in the doc.

@bmarty bmarty changed the title Split long file Split long files Aug 29, 2022
@vanniktech
Copy link
Owner

Attempt to fix or you verified that this fixes your issue?

@bmarty
Copy link
Contributor Author

bmarty commented Aug 30, 2022

I did not verify, but I will do it and let you know.

@bmarty
Copy link
Contributor Author

bmarty commented Aug 30, 2022

I have replaced the latest commit by the result of yarn start --no-copy (instead of the result of yarn start), else ./gradlew assembleRelease does not compile (duplicated images).

I confirm that the change fix the issue locally for me 🎉

@vanniktech vanniktech changed the title Split long files Generate smaller Emoji Chunks classes to avoid MethodTooLargeException Aug 30, 2022
@vanniktech vanniktech merged commit ae46e82 into vanniktech:master Aug 30, 2022
@bmarty bmarty deleted the bma/split_long_file branch August 31, 2022 08:37
@bmarty
Copy link
Contributor Author

bmarty commented Aug 31, 2022

@vanniktech thanks for merging my PR. Can I ask you when is scheduled the next release including this fix?

@vanniktech
Copy link
Owner

I can make one soon

https://www.zacsweers.dev/you-are-not-blocked/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants