Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run tests when creating the merged test coverage report. Instea… #134

Merged
merged 2 commits into from Nov 2, 2018

Conversation

vRallev
Copy link
Collaborator

@vRallev vRallev commented Oct 18, 2018

…d it's required to run specific tests manually before.

…d it's required to run specific tests manually before.
@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #134 into master will increase coverage by 19.77%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #134       +/-   ##
=============================================
+ Coverage     66.85%   86.62%   +19.77%     
- Complexity       36       37        +1     
=============================================
  Files             1        1               
  Lines           175      172        -3     
  Branches         25       24        -1     
=============================================
+ Hits            117      149       +32     
+ Misses           46       15       -31     
+ Partials         12        8        -4
Impacted Files Coverage Δ Complexity Δ
...ktech/android/junit/jacoco/GenerationPlugin.groovy 86.62% <ø> (+19.77%) 37 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79092ae...3f6a02a. Read the comment docs.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write a test for this somehow?

@vRallev
Copy link
Collaborator Author

vRallev commented Oct 18, 2018

Hm, my Gradle and Groovy voodoo isn't really strong. I'm struggling with setting up a parent with subprojects :-/

@vanniktech
Copy link
Owner

@vRallev
Copy link
Collaborator Author

vRallev commented Nov 2, 2018

@vanniktech Thanks. I finally had time to take a look. Let me know what you think.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vanniktech vanniktech merged commit c8747c0 into master Nov 2, 2018
@vanniktech vanniktech deleted the task/remove-test-task-dependency branch November 2, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants