New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run tests when creating the merged test coverage report. Instea… #134
Conversation
…d it's required to run specific tests manually before.
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=============================================
+ Coverage 66.85% 86.62% +19.77%
- Complexity 36 37 +1
=============================================
Files 1 1
Lines 175 172 -3
Branches 25 24 -1
=============================================
+ Hits 117 149 +32
+ Misses 46 15 -31
+ Partials 12 8 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we write a test for this somehow?
Hm, my Gradle and Groovy voodoo isn't really strong. I'm struggling with setting up a parent with subprojects :-/ |
Sorry. I've got sidetracked and lost this completely. You can have a look here - https://github.com/vanniktech/gradle-dependency-graph-generator-plugin/blob/c3ba1b7634436786bae5ae48c4ae57e203901d29/src/test/java/com/vanniktech/dependency/graph/generator/DependencyGraphGeneratorTest.kt#L48 - for setting up testing with parents. |
…es to the test tasks
@vanniktech Thanks. I finally had time to take a look. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…d it's required to run specific tests manually before.