Don't add jacoco tasks for ignored build variants #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a variantFilter to ignore certain variants the plugin was still generating the corresponding tasks
variantFilter { variant ->
if (variant.name == "debug") {
variant.setIgnore(true)
}
}
Caused: Could not determine the dependencies of task ':app:jacocoTestReportDebug'.
This broke the gradle `build` command
The new implementation uses android.libraryVariants or android.applicationVariants instead of iterating manually over buildTypes and flavors. The bug is fixed because ignored variants are not included.
vanniktech
approved these changes
Jul 7, 2017
There was a problem hiding this comment.
I like it. Two questions and one little nit. Also that will re-trigger the build which will hopefully let it run.
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated
| androidMock.metaClass.getBuildTypes = { buildTypesMock } | ||
| def appVariants = buildTypesMock.collect { bt -> | ||
| def variant = new MockFor(BaseVariant) | ||
| variant.metaClass.getFlavorName = { null } |
There was a problem hiding this comment.
Actually not, I just wanted to be explicit. It is required to be null
| androidMock.metaClass.getBuildTypes = { buildTypesMock } | ||
| def appVariants = buildTypesMock.collect { bt -> | ||
| def variant = new MockFor(BaseVariant) | ||
| variant.metaClass.getFlavorName = { null } |
| androidMock.metaClass.getApplicationVariants = { appVariants } | ||
| androidMock.metaClass.testOptions = null | ||
| project.metaClass.android = androidMock | ||
| // fake all with each |
There was a problem hiding this comment.
Can you transform it to a sentence?
| additionalSourceDirs = subProject.files(coverageSourceDirs) | ||
| sourceDirectories = subProject.files(coverageSourceDirs) | ||
| executionData = | ||
| subProject.files("${subProject.buildDir}/jacoco/${testTaskName}.exec") |
There was a problem hiding this comment.
can you squeeze it into one line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
The new implementation uses
android.libraryVariantsorandroid.applicationVariantsinstead of iterating manually over buildTypes and flavors. The bug is fixed because ignored variants are not included.