-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support popular JVM languages #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@@ -138,12 +138,10 @@ public class GenerationTest { | |||
|
|||
assert executionData.singleFile == project.file("${project.buildDir}/jacoco/test${flavor.capitalize()}${buildType.capitalize()}UnitTest.exec") | |||
|
|||
assert additionalSourceDirs.size() == 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you assert against the new number and also add the missing contains so that we're not missing anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? It doesn't really test anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it tests that those were configured and in this case when something was added it'll fail.
"src/main/java", | ||
"src/main/kotlin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about src/$buildTypeName/kotlin
and the others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true they also need to be added.
Can you please accept this? |
@vanniktech Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing now 👍 thanks a lot <3
Do we have a time frame for release on this change? |
@kingargyle According to #73 (comment), he said he would release last night. @vanniktech Did you release last night? |
I see it in the Snapshots repository. But would prefer to get it from central or jcenter officially. https://oss.sonatype.org/#nexus-search;quick~gradle-android-junit-jacoco-plugin |
I'll release tonight, meaning soon given that I'm living in Europe :D |
@jaredsburrows @kingargyle @guitcastro @passsy I released 0.7.0 - thanks a lot for all of your help 🍻 |
@vanniktech @jaredsburrows tested this tonight and works well. Thanks again! |
@vanniktech
Closes #74
Based on popular JVM languages: https://www.slant.co/topics/397/~best-languages-that-run-on-the-jvm
Officially supported by Android: Java + Android
Other popular languages supported by Gradle plugins for Android:
https://github.com/JetBrains/kotlin/tree/master/libraries/tools/kotlin-gradle-plugin
https://github.com/groovy/groovy-android-gradle-plugin
https://github.com/scala-android/sbt-android
https://github.com/clojure-android/android-clojure-plugin