Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support popular JVM languages #75

Merged
merged 2 commits into from
Aug 2, 2017
Merged

Support popular JVM languages #75

merged 2 commits into from
Aug 2, 2017

Conversation

jaredsburrows
Copy link
Contributor

@jaredsburrows jaredsburrows commented Jul 31, 2017

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vanniktech vanniktech closed this Jul 31, 2017
@vanniktech vanniktech reopened this Jul 31, 2017
@@ -138,12 +138,10 @@ public class GenerationTest {

assert executionData.singleFile == project.file("${project.buildDir}/jacoco/test${flavor.capitalize()}${buildType.capitalize()}UnitTest.exec")

assert additionalSourceDirs.size() == 3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you assert against the new number and also add the missing contains so that we're not missing anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? It doesn't really test anything.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it tests that those were configured and in this case when something was added it'll fail.

"src/main/java",
"src/main/kotlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about src/$buildTypeName/kotlin and the others?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true they also need to be added.

@guitcastro
Copy link

Can you please accept this?

@jaredsburrows
Copy link
Contributor Author

@vanniktech Updated.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing now 👍 thanks a lot <3

@vanniktech vanniktech merged commit 4bc2c68 into vanniktech:master Aug 2, 2017
@jaredsburrows jaredsburrows deleted the jb/sourcesets branch August 2, 2017 07:29
@kingargyle
Copy link

Do we have a time frame for release on this change?

@jaredsburrows
Copy link
Contributor Author

@kingargyle According to #73 (comment), he said he would release last night.

@vanniktech Did you release last night?

@kingargyle
Copy link

I see it in the Snapshots repository. But would prefer to get it from central or jcenter officially.

https://oss.sonatype.org/#nexus-search;quick~gradle-android-junit-jacoco-plugin

@vanniktech
Copy link
Owner

I'll release tonight, meaning soon given that I'm living in Europe :D

@vanniktech
Copy link
Owner

@jaredsburrows @kingargyle @guitcastro @passsy I released 0.7.0 - thanks a lot for all of your help 🍻

@kingargyle
Copy link

@vanniktech @jaredsburrows tested this tonight and works well. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants