add workaround for test fixtures issue #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
approved these changes
Jan 2, 2023
|
Needed to change the code a bit and use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started happening now because of the change to not set project.group and version anymore. As a workaround we will start doing that again but only when the test-fixtures plugin is applied. Unfortunately there doesn't seem to be a way to modify capabilities. The only other way would be to rewrite the generated metadata file on our own but that seems a lot more error prone to me.
@ZacSweers already tested this manually in eithernet slackhq/EitherNet@27270d7
Filed Gradle issue gradle/gradle#23354