Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Xcode 10.2.1 (pods, proj metadata and Swift) #75

Merged
merged 4 commits into from
Jun 3, 2019

Conversation

karol-depka
Copy link
Contributor

No description provided.

@vanshg
Copy link
Owner

vanshg commented May 31, 2019

Hi @karol-depka, thanks for the contribution! Looks like the CI is failing and I think it's because of Xcode version that Azure is using to build. (see: https://github.com/Microsoft/azure-pipelines-image-generation/tree/master/images/macos). Could you also update the azure-ci.yml file from vmImage: 'macOS 10.13' to vmImage: 'macOS 10.14'. That will use Xcode 10.2.1 by default, which is what you have compiled with. I think then the CI will pass, and I can get this merged.

@vanshg
Copy link
Owner

vanshg commented Jun 3, 2019

LGTM!

@vanshg vanshg merged commit 21c4537 into vanshg:master Jun 3, 2019
@karol-depka
Copy link
Contributor Author

Cool. Thanks :).
Any way/plans to allow the assistant "to use a screen" ?

@vanshg
Copy link
Owner

vanshg commented Jun 4, 2019

What do you mean by use a screen?

@longnd
Copy link

longnd commented Jun 26, 2019

chalk-google-smart-assistants-ga00516-us-64_1000
I guess that means to visualize the response - like what Google home hub does.
But I don't think it's possible.

@vanshg
Copy link
Owner

vanshg commented Jun 27, 2019

There is an htmlOut field returned by the Assistant API so it might be possible

hinata1710 added a commit to hinata1710/MacAssistant that referenced this pull request May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants