Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CalendarDay): add default margin-bottom #10441

Merged
merged 7 commits into from Mar 31, 2022

Conversation

nemo-shen
Copy link
Contributor

@nemo-shen nemo-shen commented Mar 27, 2022

#10440

调整

  • CalendarDay 默认 marginBottom = 10px
  • 每月最后一周日期默认 marginBottom = 0

discuss

  • APP上的携程、美团等样式均有10px间距,然而网页版的均无marginBottom,个人审美感觉加上后会美观点

@chenjiahan
Copy link
Member

10px 太大了,导致信息密度下降严重,Demo 上都无法完整展示一个月的完整日期了,这里要加的话 4px 就够了

@nemo-shen
Copy link
Contributor Author

ok 我调整下嗷

@chenjiahan chenjiahan changed the title feat(CalendarDay): add default margin-bottom 10px #10440 feat(CalendarDay): add default margin-bottom Mar 31, 2022
@chenjiahan chenjiahan merged commit a1054c3 into youzan:dev Mar 31, 2022
@nemo-shen nemo-shen deleted the feature/calendar-day_add_margin_0327 branch March 31, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants